Use image_shape for SD3
#1979
Merged
Use image_shape for SD3
#1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james77777778
requested review from
fchollet,
MarkDaoust and
pcoet
as code owners
fchollet
reviewed
Oct 24, 2024
| @@ -107,7 +107,7 @@ def display_generated_images(images): | |||
|
|
|||
|
|
|||
| backbone = keras_hub.models.StableDiffusion3Backbone.from_preset( | |||
| "stable_diffusion_3_medium", height=512, width=512, dtype="float16" | |||
| "stable_diffusion_3_medium", image_shape=(512, 512, 3), dtype="float16" | |||
There was a problem hiding this comment.
Why does the channel axis need to be specified? Other APIs that an image_shape arg only do height/width
There was a problem hiding this comment.
Is it true? I think most of the backbones in kerashub expect (h, w, c) format using image_shape.
https://github.com/search?q=repo%3Akeras-team%2Fkeras-hub%20image_shape&type=code
This change was requested by @divyashreepathihalli and I agree that it is more consistent with other backbone APIs
Additionally, even though most users won’t do this, it is still valid to train a diffusion model with the non-standard RGB images.
EDITED:
We need to specify channel axis to correctly instantiate VAE image encoder.
fchollet
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SD3 guide needs to be updated once we have a new release of
keras-hub, as keras-team/keras-hub#1951 has been mergedcc @divyashreepathihalli