Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf.keras.layers.Attention() layer - arguments documentation #171

Closed
8bitmp3 opened this issue Jul 30, 2020 · 3 comments · Fixed by keras-team/keras#18205
Closed

tf.keras.layers.Attention() layer - arguments documentation #171

8bitmp3 opened this issue Jul 30, 2020 · 3 comments · Fixed by keras-team/keras#18205
Assignees
@sachinprasadhs
Labels
stale stat:awaiting response from contributor type:docs-bug

Comments

@8bitmp3
Copy link
Contributor

8bitmp3 commented Jul 30, 2020

Hey Keras team, I've just discovered a potential Markdown rendering issue in the docs for the Attention class (tf.keras.layers.Attention()).

Link: https://keras.io/api/layers/attention_layers/attention/

See Call # Arguments ...:

image
@sachinprasadhs sachinprasadhs mentioned this issue Jun 7, 2023
Merged
@sachinprasadhs sachinprasadhs self-assigned this Jun 7, 2023
@copybara-service copybara-service bot mentioned this issue Jun 8, 2023
Closed
copybara-service bot pushed a commit to keras-team/keras that referenced this issue Jun 8, 2023
@sachinprasadhs @tensorflower-gardener
PR #18205: Fix markdown rendering issue
46560dd 
Imported from GitHub PR #18205

Fix markdown rendering issue in keras.io in the call argument section.
Closes: keras-team/keras-io#171
Copybara import of the project:

--
012109f by Sachin Prasad <[email protected]>:

Fix markdown rendering issue

Fix markdown rendering issue in keras.io in the call argument section.
--
311b0ac by Sachin Prasad <[email protected]>:

Fix markdown rendering issue
--
b518168 by Sachin Prasad <[email protected]>:

Update base_dense_attention.py

Merging this change closes #18205

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18205 from keras-team:sachinprasadhs-patch-6 b518168
PiperOrigin-RevId: 538823421
copybara-service bot pushed a commit to keras-team/keras that referenced this issue Jun 8, 2023
@sachinprasadhs @tensorflower-gardener
PR #18205: Fix markdown rendering issue
e62186d 
Imported from GitHub PR #18205

Fix markdown rendering issue in keras.io in the call argument section.
Closes: keras-team/keras-io#171
Copybara import of the project:

--
012109f by Sachin Prasad <[email protected]>:

Fix markdown rendering issue

Fix markdown rendering issue in keras.io in the call argument section.
--
311b0ac by Sachin Prasad <[email protected]>:

Fix markdown rendering issue
--
b518168 by Sachin Prasad <[email protected]>:

Update base_dense_attention.py

Merging this change closes #18205

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18205 from keras-team:sachinprasadhs-patch-6 b518168
PiperOrigin-RevId: 538823421
@sachinprasadhs
Copy link
Collaborator

Hi @8bitmp3 , Thanks for reporting the issue, the linked PR has been merged, could you please spare some time to close the issue as well. Thanks!

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Jun 30, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 28 days. Please reopen if you'd like to work on this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinprasadhs sachinprasadhs

Labels
stale stat:awaiting response from contributor type:docs-bug
Projects
None yet
Milestone
No milestone
2 participants
@8bitmp3 @sachinprasadhs