Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Defaults to to end of arg docstring and standardise values #1057

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Move Defaults to to end of arg docstring and standardise values #1057

merged 4 commits into from
Jun 2, 2023

Conversation

SamuelMarks
Copy link
Contributor

What does this PR do?

Hey it's that annoying fellow again, the one from keras-team/keras#17748

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

mattdangerw
mattdangerw approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. Dropped a few minor comments.

keras_nlp/layers/f_net_encoder.py Outdated Show resolved Hide resolved
keras_nlp/layers/f_net_encoder.py Outdated Show resolved Hide resolved
keras_nlp/layers/f_net_encoder.py Outdated Show resolved Hide resolved
keras_nlp/layers/masked_lm_head.py Outdated Show resolved Hide resolved
keras_nlp/layers/masked_lm_head.py Outdated Show resolved Hide resolved
keras_nlp/layers/masked_lm_mask_generator.py Outdated Show resolved Hide resolved
keras_nlp/layers/transformer_decoder.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/word_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit d710249 into keras-team:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelMarks @mattdangerw