Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds JAX version checking for Export #923

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

nkovela1
Copy link
Collaborator

This PR is a temporary fix in response to the incompatibility between the latest JAX release and latest stable TF release, affecting the export API and its use of JAX2TF.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (c64de55) 79.73% compared to head (0e7cbb9) 79.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.02%     
==========================================
  Files         318      318              
  Lines       28627    28631       +4     
  Branches     5447     5449       +2     
==========================================
  Hits        22827    22827              
- Misses       4333     4336       +3     
- Partials     1467     1468       +1     
Flag Coverage Δ
keras_core 79.65% <0.00%> (-0.02%) ⬇️
keras_core-numpy 60.38% <0.00%> (-0.01%) ⬇️
keras_core-tensorflow 66.81% <0.00%> (-0.01%) ⬇️
keras_core-torch 69.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/export/export_lib.py 77.72% <0.00%> (-1.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 1f9dd43 into keras-team:main Sep 19, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants