Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model.save API for legacy H5 format #891

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Conversation

nkovela1
Copy link
Collaborator

model.save was not updated to reflect the legacy format's existence. This keeps the API in line with keras.saving.save_model.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (94b5361) 76.56% compared to head (33b5f6f) 76.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   76.56%   76.61%   +0.05%     
==========================================
  Files         329      329              
  Lines       31429    31437       +8     
  Branches     6114     6116       +2     
==========================================
+ Hits        24064    24086      +22     
+ Misses       5786     5779       -7     
+ Partials     1579     1572       -7     
Flag Coverage Δ
keras_core 76.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/models/model.py 71.83% <100.00%> (+4.97%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/models/model.py Outdated Show resolved Hide resolved
keras_core/models/model.py Outdated Show resolved Hide resolved
keras_core/models/model.py Outdated Show resolved Hide resolved
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit a94aea0 into keras-team:main Sep 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants