Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tests in utils #880

Conversation

Faisal-Alsrheed
Copy link
Contributor

@Faisal-Alsrheed Faisal-Alsrheed commented Sep 14, 2023

This PR aims to increase the test coverage for the keras_core/utils module.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.22% 🎉

Comparison is base (bb21710) 76.49% compared to head (362b322) 76.71%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   76.49%   76.71%   +0.22%     
==========================================
  Files         329      329              
  Lines       31334    31429      +95     
  Branches     6100     6114      +14     
==========================================
+ Hits        23970    24112     +142     
+ Misses       5785     5737      -48     
- Partials     1579     1580       +1     
Flag Coverage Δ
keras_core 76.62% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase tests in utils + Fix Bug in count_loc Increase tests in utils Sep 14, 2023
@Faisal-Alsrheed Faisal-Alsrheed marked this pull request as ready for review September 14, 2023 19:26
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@fchollet fchollet merged commit 7486af9 into keras-team:main Sep 15, 2023
8 checks passed
@Faisal-Alsrheed Faisal-Alsrheed deleted the Increase-test-coverage-keras_core-utils-14-9-2023 branch September 16, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants