Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage in keras_core/utils #856

Merged
merged 10 commits into from
Sep 10, 2023

Conversation

Faisal-Alsrheed
Copy link
Contributor

@Faisal-Alsrheed Faisal-Alsrheed commented Sep 9, 2023

Increase test coverage in Increase test coverage in keras_core/utils

@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase-test-coverage in keras_core/utils Increase test coverage + Fixing bug in remove_long_seq Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (ac9be33) 76.03% compared to head (3f7cd6b) 76.15%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   76.03%   76.15%   +0.12%     
==========================================
  Files         328      329       +1     
  Lines       31136    31270     +134     
  Branches     6061     6083      +22     
==========================================
+ Hits        23673    23814     +141     
+ Misses       5866     5857       -9     
- Partials     1597     1599       +2     
Flag Coverage Δ
keras_core 76.06% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase test coverage + Fixing bug in remove_long_seq Increase test coveragein keras_core/utils + Fixing bug in remove_long_seq Sep 9, 2023
@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase test coveragein keras_core/utils + Fixing bug in remove_long_seq Increase test coverage in keras_core/utils + Fixing bug in remove_long_seq Sep 9, 2023
@Faisal-Alsrheed Faisal-Alsrheed marked this pull request as ready for review September 9, 2023 08:38
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/utils/python_utils.py Outdated Show resolved Hide resolved
@Faisal-Alsrheed Faisal-Alsrheed changed the title Increase test coverage in keras_core/utils + Fixing bug in remove_long_seq Increase test coverage in keras_core/utils Sep 9, 2023
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@fchollet fchollet merged commit f2d9838 into keras-team:main Sep 10, 2023
8 checks passed
@Faisal-Alsrheed Faisal-Alsrheed deleted the Increase-test-coverage-V3 branch September 16, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants