Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "mse" as the metric name in the log #812

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

haifeng-jin
Copy link
Collaborator

The name "mse" was not kept as the name as the metric, but used "mean_square_error" instead, when model.compile(..., metrics=["mse"]).

The cause of the bug is custom names were only assigned when creating MeanMetricWrapper from Metric, but some metrics were created directly by deserialization as a MeanMetricWrapper.

The solution is to do the name assignment for all metrics before returning.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit ca1a177 into keras-team:main Aug 29, 2023
6 checks passed
@haifeng-jin haifeng-jin deleted the bug2 branch August 29, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants