Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tab transformer example to keras core #621

Merged
merged 6 commits into from
Aug 26, 2023

Conversation

anas-rz
Copy link
Contributor

@anas-rz anas-rz commented Jul 27, 2023

Port tab transformer example to keras core. Tried testing on all backends and the StringLookup layer doesn't work with torch and jax backends. COLAB to reproduce

@fchollet
Copy link
Member

Tried testing on all backends and the StringLookup layer doesn't work with torch and jax backends

Other backends don't have a string dtype, so you won't be able to include the StringLookup layer in the model. The solution would be to move string preprocessing outside the model, to the tf.data pipeline.

@anas-rz
Copy link
Contributor Author

anas-rz commented Jul 30, 2023

Please consider the latest commit. I accidentally put the same old code in the previous commit.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Sorry for the delay in reviewing, I had lost track of this.

@fchollet fchollet merged commit 67626f9 into keras-team:main Aug 26, 2023
6 checks passed
@anas-rz anas-rz deleted the port-tab-transformer branch August 26, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants