Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

Better to separate blacklist.txt #16

Closed
ghost opened this issue Sep 19, 2017 · 6 comments
Closed

Better to separate blacklist.txt #16

ghost opened this issue Sep 19, 2017 · 6 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 19, 2017

I would suggest to separate blacklist.txt as a different project, so that other extensions, apps and services can utilize and integrate it. It would be much easier to update the list too, without updating the NoCoin extension frequently.

@keraf
Copy link
Owner

keraf commented Sep 19, 2017

Thanks for the suggestion, that's a good idea. I'll add that to my priorities.

@keraf keraf self-assigned this Sep 20, 2017
@keraf keraf mentioned this issue Sep 21, 2017
@keraf
Copy link
Owner

keraf commented Sep 21, 2017

The extension is now loading the blacklist from Github. I have decided not to separate it from the project as the location is not likely to change in the future. I guess if other projects wish to use it, it's fairly safe to point it to: https://raw.githubusercontent.com/keraf/NoCoin/master/src/blacklist.txt

@keraf keraf closed this as completed Sep 21, 2017
@suhail-sullad
Copy link
Contributor

URL returned 404.

@keraf
Copy link
Owner

keraf commented Sep 21, 2017

Good catch, thanks! Some chars snuck in before my commit. That's fixed now!

@suhail-sullad
Copy link
Contributor

Also i think we should add response empty or null check before going into fallback. Sending a PR now.

@ghost
Copy link
Author

ghost commented Sep 21, 2017

created a Adblock Plus filter list based on the blacklist.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants