This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Better to separate blacklist.txt #16
Labels
Comments
Thanks for the suggestion, that's a good idea. I'll add that to my priorities. |
The extension is now loading the blacklist from Github. I have decided not to separate it from the project as the location is not likely to change in the future. I guess if other projects wish to use it, it's fairly safe to point it to: https://raw.githubusercontent.com/keraf/NoCoin/master/src/blacklist.txt |
URL returned 404. |
Good catch, thanks! Some chars snuck in before my commit. That's fixed now! |
Also i think we should add response empty or null check before going into fallback. Sending a PR now. |
created a Adblock Plus filter list based on the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I would suggest to separate blacklist.txt as a different project, so that other extensions, apps and services can utilize and integrate it. It would be much easier to update the list too, without updating the NoCoin extension frequently.
The text was updated successfully, but these errors were encountered: