Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change Development url #923

Merged
merged 3 commits into from
Mar 8, 2023
Merged

docs: change Development url #923

merged 3 commits into from
Mar 8, 2023

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Feb 28, 2023

We thought we could have a nicer url with dev. but it seems like this is not working (or at least we did not manage).

As this is not mission critical we change it to simply use the branch name, which works, and in fact needs lesser configuration.

We thought we could have a nicer url with `dev.` but it seems
like this is not working (or at least we did not manage).

As this is not mission critical we change it to simply use the
branch name, which works, and in fact needs lesser configuration.

Additionally fixing other urls too
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli added the documentation Improvements or additions to documentation label Feb 28, 2023
@aepfli aepfli mentioned this pull request Mar 1, 2023
10 tasks
Signed-off-by: Simon Schrottner <[email protected]>
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit b96cf65
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64084e66ebfc100008774fe6
😎 Deploy Preview https://deploy-preview-923--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thisthat
thisthat previously approved these changes Mar 8, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, fix the DCO @aepfli
The PR looks good to me! ✅

Signed-off-by: Simon Schrottner <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat merged commit 335722d into keptn:main Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 8, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants