Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): Get desired amount of replicas from upper level resource #89

Merged
merged 5 commits into from
Oct 4, 2022
Merged

fix(operator): Get desired amount of replicas from upper level resource #89

merged 5 commits into from
Oct 4, 2022

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Oct 3, 2022

Signed-off-by: Thomas Schuetz [email protected]

@thschue thschue marked this pull request as ready for review October 3, 2022 16:28
@thschue thschue requested a review from odubajDT October 3, 2022 16:33
@odubajDT
Copy link
Contributor

odubajDT commented Oct 4, 2022 •
edited
Loading

please execute make manifests so the rbac changes get applied

@thschue
Copy link
Contributor Author

thschue commented Oct 4, 2022

please execute make manifests so the rbac changes get applied

done

odubajDT
odubajDT previously approved these changes Oct 4, 2022
View reviewed changes
@mowies mowies changed the title fix(operator): get desired amount of replicas from upper level resource fix(operator): Get desired amount of replicas from upper level resource Oct 4, 2022
chore(operator): fix rbac
19fc449 
Signed-off-by: Thomas Schuetz <[email protected]>
mowies
mowies approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thschue thschue merged commit 6767832 into main Oct 4, 2022
@thschue thschue deleted the fix_pod_count branch October 4, 2022 07:53
@github-actions github-actions bot mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@thisthat thisthat thisthat approved these changes

@odubajDT odubajDT odubajDT left review comments

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thschue @odubajDT @thisthat @mowies