Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: initial list of related technologies of Keptn #795

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

sudiptob2
Copy link
Member

Ref: #733

I have compiled a preliminary list of supplementary technologies associated with Keptn, as several new individuals have expressed interest in obtaining this information. This list has been assembled from the contributions provided by members of the community. If you have any additional resources that need to be included, kindly inform us.

@sudiptob2 sudiptob2 marked this pull request as ready for review February 9, 2023 04:12
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sudiptob2 sudiptob2 force-pushed the docs/733/ancillary-technologies-ref branch from 2cd7a86 to 8b047aa Compare February 9, 2023 12:40
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Just a couple comments and others should validate that these are good materials to use.

thschue
thschue previously approved these changes Feb 9, 2023
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #795 (f76b84d) into main (8c4ba83) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head f76b84d differs from pull request most recent head f6b580d. Consider uploading reports for the commit f6b580d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   58.60%   58.41%   -0.19%     
==========================================
  Files          97       97              
  Lines        7552     7518      -34     
==========================================
- Hits         4426     4392      -34     
- Misses       2935     2937       +2     
+ Partials      191      189       -2     
Impacted Files Coverage Δ
operator/controllers/common/otel_utils.go 66.17% <0.00%> (-4.47%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 53.93% <0.00%> (-1.02%) ⬇️
...rator/controllers/lifecycle/keptnapp/controller.go 68.42% <0.00%> (-0.55%) ⬇️
...ontrollers/lifecycle/keptnappversion/controller.go 72.51% <0.00%> (-0.42%) ⬇️
...ontrollers/lifecycle/keptnevaluation/controller.go 81.28% <0.00%> (-0.22%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 82.80% <0.00%> (-0.16%) ⬇️
operator/controllers/common/metrics.go 84.48% <0.00%> (+5.07%) ⬆️
Flag Coverage Δ
component-tests 42.31% <ø> (+0.11%) ⬆️
keptn-lifecycle-operator 54.50% <ø> (-0.17%) ⬇️
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thisthat
thisthat previously approved these changes Feb 22, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sudiptob2 sudiptob2 dismissed stale reviews from thisthat and thschue via 6c4ac1e February 22, 2023 13:20
@sudiptob2 sudiptob2 force-pushed the docs/733/ancillary-technologies-ref branch from f76b84d to 6c4ac1e Compare February 22, 2023 13:20
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for keptn-lifecyle-testing ready!

Name Link
🔨 Latest commit 6c4ac1e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecyle-testing/deploys/63f616af7d03dd00089462a6
😎 Deploy Preview https://deploy-preview-795--keptn-lifecyle-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thisthat
thisthat previously approved these changes Feb 27, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sudiptob2 LGTM! :shipit:

@mowies mowies changed the title docs: initial list of ancillary technologies of Keptn. docs: initial list of ancillary technologies of Keptn Feb 27, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls exchange ancillary for related :)
also you have some markdown lint checks that are failing. you can check those by running make markdownlint from the root folder

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mowies mowies changed the title docs: initial list of ancillary technologies of Keptn docs: initial list of related technologies of Keptn Feb 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sudiptob2
Copy link
Member Author

sudiptob2 commented Feb 27, 2023

also you have some markdown lint checks that are failing. you can check those by running make markdownlint from the root folder

@mowies Thanks for the review. Fixed the markdown errors in the contributing.md. However, when I run make markdownlint I see a lot of lining errors in other files. I see those errors only on my local machine. In the pipeline, I saw errors on the contributing.md only.

@sudiptob2 sudiptob2 requested a review from mowies February 27, 2023 12:19
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudiptob2 sudiptob2 requested a review from thisthat February 28, 2023 08:06
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants