-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): accept LogLevels for all controllers #790
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 58.59% 58.60% +0.01%
==========================================
Files 97 97
Lines 7552 7552
==========================================
+ Hits 4425 4426 +1
+ Misses 2936 2935 -1
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. |
8d1359f
to
d48a428
Compare
@RealAnna opts := zap.Options{
Development: true,
}
opts.BindFlags(flag.CommandLine) At this time we can define the log level as opts := zap.Options{
Development: true,
Level: env.SomeControllerLogLevel
} But definitely, we want to configure the different log levels for different controllers. In this case what I think we can do is, patch the log level after the definition of each taskReconciler.Log.V(env.SomeControllerLogLevel) However, I am unsure about the syntax, because I would appreciate it tremendously if you could guide me in this case. |
d48a428
to
3f419d0
Compare
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
…tance controller log level(keptn#724) Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]>
05be94e
to
a494d86
Compare
Signed-off-by: Giovanni Liva <[email protected]>
✅ Deploy Preview for keptn-lifecyle-testing ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👍 Thanks @sudiptob2
Signed-off-by: Giovanni Liva <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Sudipto Baral <[email protected]> Signed-off-by: Giovanni Liva <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Amishakumari544 <[email protected]>
Signed-off-by: Sudipto Baral <[email protected]> Signed-off-by: Giovanni Liva <[email protected]> Co-authored-by: Giovanni Liva <[email protected]>
Fixes #724
Checklist
loglevel
valuesloglevel
values from theenv