Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated path to observability folder #780

Merged

Conversation

sudiptob2
Copy link
Member

Fixes #779

Path to the observability folder updated for make commands

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #780 (9625261) into main (f2263b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files          91       91           
  Lines        7243     7243           
=======================================
  Hits         4179     4179           
  Misses       2894     2894           
  Partials      170      170           
Flag Coverage Δ
component-tests 47.77% <ø> (ø)
keptn-lifecycle-operator 53.60% <ø> (ø)
klt-cert-manager 67.50% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, lgtm!

Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but someone else needs to verify it

@thisthat thisthat merged commit f2f09ea into keptn:main Feb 7, 2023
@keptn-bot keptn-bot mentioned this pull request Feb 7, 2023
@sudiptob2 sudiptob2 deleted the fix/779/wrong-path-to-observability-folder branch February 7, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path to the observability folder in the sample app Makefile
5 participants