Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable imagePullPolicy via Helm #740

Merged
merged 15 commits into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ manifests/
## Kubebuilder
**/kubebuilder
/docs/tmp/

# Helm readme generator project
readme-generator-for-helm/
7 changes: 4 additions & 3 deletions helm/chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ KLT introduces a more cloud-native approach for pre- and post-deployment, as wel

### OpenTelemetry

| Name | Description | Value |
| ------------------- | --------------------------------------------- | --------------------- |
| `otelCollector.url` | Sets the URL for the open telemetry collector | `otel-collector:4317` |
| Name | Description | Value |
| ---------------------------- | ---------------------------------------------------- | --------------------- |
| `otelCollector.url` | Sets the URL for the open telemetry collector | `otel-collector:4317` |
| `deployment.imagePullPolicy` | Sets the image pull policy for kubernetes deployment | `Always` |

4 changes: 4 additions & 0 deletions helm/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
otelCollector:
## @param otelCollector.url Sets the URL for the open telemetry collector
url: "otel-collector:4317"

deployment:
## @param deployment.imagePullPolicy Sets the image pull policy for kubernetes deployment
imagePullPolicy: "Always"
31 changes: 19 additions & 12 deletions helm/overlay/patches/patch_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,28 @@ spec:
spec:
containers:
- name: manager
imagePullPolicy: "{{ .Values.deployment.imagePullPolicy | default Always }}"
sudiptob2 marked this conversation as resolved.
Show resolved Hide resolved

env:
- name: OTEL_COLLECTOR_URL
value: "{{ .Values.otelCollector.url }}"


#---
#apiVersion: apps/v1 #example patch for certmanager
#kind: Deployment
#metadata:
# name: cert-manager
# namespace: system
#spec:
# template:
# spec:
# containers:
# - name: manager
# env:

---
apiVersion: apps/v1
kind: Deployment
metadata:
name: cert-manager
namespace: system
spec:
template:
spec:
containers:
- name: manager
imagePullPolicy: "{{ .Values.deployment.imagePullPolicy | default Always }}"
sudiptob2 marked this conversation as resolved.
Show resolved Hide resolved

env:
# - name: NEW_ENV_VAR
# value: "{{ .Values.myNewEnvVar }}"

Expand All @@ -40,6 +45,8 @@ spec:
spec:
containers:
- name: keptn-scheduler
imagePullPolicy: "{{ .Values.deployment.imagePullPolicy | default Always }}"
sudiptob2 marked this conversation as resolved.
Show resolved Hide resolved

env:
- name: OTEL_COLLECTOR_URL
value: "{{ .Values.otelCollector.url }}"
Expand Down