Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): fix linter issues #579

Merged
merged 14 commits into from
Jan 12, 2023
Merged

chore(operator): fix linter issues #579

merged 14 commits into from
Jan 12, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 10, 2023

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #485

  • introduce linter ignorers on places where it does not makes sense to refactor (reduces readability and possible changes options, increases complexity)
  • refactoring -> reducing complexity of functions according to linter errors

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #579 (6304702) into main (9b31b04) will increase coverage by 0.19%.
The diff coverage is 58.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   53.14%   53.34%   +0.19%     
==========================================
  Files          69       69              
  Lines        5903     6003     +100     
==========================================
+ Hits         3137     3202      +65     
- Misses       2659     2690      +31     
- Partials      107      111       +4     
Impacted Files Coverage Δ
...s/lifecycle/v1alpha1/keptnappversion_conversion.go 100.00% <ø> (ø)
...cle/v1alpha1/keptnevaluationprovider_conversion.go 100.00% <ø> (ø)
...r/apis/lifecycle/v1alpha2/keptnappversion_types.go 97.52% <ø> (ø)
.../lifecycle/v1alpha2/keptnworkloadinstance_types.go 95.16% <ø> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 0.00% <0.00%> (ø)
operator/webhooks/pod_mutating_webhook.go 35.83% <ø> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 38.31% <35.29%> (-1.69%) ⬇️
...lers/lifecycle/keptnworkloadinstance/controller.go 78.24% <72.72%> (-0.85%) ⬇️
operator/controllers/common/taskhandler.go 79.71% <81.81%> (+1.63%) ⬆️
operator/controllers/common/evaluationhandler.go 79.71% <82.08%> (+1.63%) ⬆️
... and 14 more
Flag Coverage Δ
component-tests 53.33% <57.24%> (+2.50%) ⬆️
keptn-lifecycle-operator 51.60% <54.79%> (+0.28%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review January 11, 2023 09:53
mowies
mowies previously approved these changes Jan 11, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes Jan 12, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes Jan 12, 2023
odubajDT and others added 2 commits January 12, 2023 09:52
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@odubajDT odubajDT merged commit 64603fb into keptn:main Jan 12, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter issues
3 participants