-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(operator): fix linter issues #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 53.14% 53.34% +0.19%
==========================================
Files 69 69
Lines 5903 6003 +100
==========================================
+ Hits 3137 3202 +65
- Misses 2659 2690 +31
- Partials 107 111 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
mowies
previously approved these changes
Jan 11, 2023
bacherfl
reviewed
Jan 12, 2023
bacherfl
reviewed
Jan 12, 2023
operator/controllers/lifecycle/keptnworkloadinstance/controller.go
Outdated
Show resolved
Hide resolved
bacherfl
previously approved these changes
Jan 12, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
previously approved these changes
Jan 12, 2023
mowies
reviewed
Jan 12, 2023
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
mowies
approved these changes
Jan 12, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please retry analysis of this Pull-Request directly on SonarCloud. |
bacherfl
approved these changes
Jan 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com
Fixes: #485