Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Application discovery #559

Closed
wants to merge 6 commits into from

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jan 4, 2023

This is an experimental PR with a poc implementation of #517

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #559 (502d0f4) into main (9e8b305) will decrease coverage by 0.02%.
The diff coverage is 5.30%.

❗ Current head 502d0f4 differs from pull request most recent head 74b2634. Consider uploading reports for the commit 74b2634 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   49.74%   49.72%   -0.03%     
==========================================
  Files          60       60              
  Lines        5528     5539      +11     
==========================================
+ Hits         2750     2754       +4     
- Misses       2668     2673       +5     
- Partials      110      112       +2     
Impacted Files Coverage Δ
operator/api/v1alpha2/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
operator/webhooks/pod_mutating_webhook.go 35.83% <0.00%> (ø)
...or/controllers/keptnworkloadinstance/controller.go 78.26% <100.00%> (-0.83%) ⬇️
operator/controllers/keptntask/controller.go 53.93% <0.00%> (-3.38%) ⬇️
Flag Coverage Δ
component-tests 49.64% <83.33%> (-0.79%) ⬇️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants