Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement security pipeline #549

Merged
merged 14 commits into from
Jan 2, 2023

Conversation

philipp-hinteregger
Copy link
Contributor

@philipp-hinteregger philipp-hinteregger commented Dec 20, 2022

This PR

  • creates a security pipeline to check the project with:
    • KICS
    • Kubescape
    • Kubeconform
    • Govulncheck
    • Trivy
  • contains initial security fixes
  • fixes: Security pipeline #341

Example run on fork

Signed-off-by: Philipp Hinteregger [email protected]

Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #549 (21070bb) into main (c661dc0) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   49.61%   49.69%   +0.07%     
==========================================
  Files          60       60              
  Lines        5486     5528      +42     
==========================================
+ Hits         2722     2747      +25     
- Misses       2656     2670      +14     
- Partials      108      111       +3     
Impacted Files Coverage Δ
operator/controllers/keptnapp/controller.go 68.42% <0.00%> (-9.23%) ⬇️
operator/webhooks/pod_mutating_webhook.go 35.83% <0.00%> (-0.11%) ⬇️
operator/api/v1alpha2/keptnapp_types.go 91.66% <0.00%> (ø)
...ator/api/v1alpha2/keptnevaluationprovider_types.go 100.00% <0.00%> (ø)
operator/api/v1alpha2/keptnappversion_types.go 97.52% <0.00%> (+0.08%) ⬆️
...or/controllers/keptnworkloadinstance/controller.go 79.08% <0.00%> (+0.21%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 50.43% <ø> (-0.70%) ⬇️
keptn-lifecycle-operator 47.58% <ø> (+0.09%) ⬆️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@philipp-hinteregger philipp-hinteregger changed the title ci: implement a security pipeline ci: implement security pipeline Dec 21, 2022
@philipp-hinteregger philipp-hinteregger marked this pull request as ready for review December 21, 2022 06:26
.github/kics-config.yml Outdated Show resolved Hide resolved
.github/workflows/security-scans.yml Outdated Show resolved Hide resolved
.github/workflows/security-scans.yml Outdated Show resolved Hide resolved
.snyk Outdated Show resolved Hide resolved
functions-runtime/Dockerfile Show resolved Hide resolved
Signed-off-by: Philipp Hinteregger <[email protected]>
Signed-off-by: Philipp Hinteregger <[email protected]>
thisthat
thisthat previously approved these changes Dec 21, 2022
.github/.kubescape/controls-inputs.json Outdated Show resolved Hide resolved
.github/.kubescape/exceptions.json Outdated Show resolved Hide resolved
.github/workflows/security-scans.yml Show resolved Hide resolved
.github/workflows/security-scans.yml Outdated Show resolved Hide resolved
.github/workflows/security-scans.yml Outdated Show resolved Hide resolved
.github/workflows/security-scans.yml Outdated Show resolved Hide resolved
Signed-off-by: Philipp Hinteregger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 9e8b305 into keptn:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security pipeline
4 participants