Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linter issues #488

Closed
wants to merge 23 commits into from
Closed

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 30, 2022

Fixes #485

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #488 (1382534) into main (1b3a56f) will decrease coverage by 0.11%.
The diff coverage is 72.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   59.43%   59.32%   -0.12%     
==========================================
  Files          28       28              
  Lines        2098     2198     +100     
==========================================
+ Hits         1247     1304      +57     
- Misses        746      787      +41     
- Partials      105      107       +2     
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 73.30% <60.29%> (-3.50%) ⬇️
operator/controllers/keptnappversion/controller.go 72.30% <65.85%> (ø)
operator/controllers/common/evaluationhandler.go 65.24% <81.72%> (-12.83%) ⬇️
operator/controllers/common/phasehandler.go 84.50% <84.61%> (+3.55%) ⬆️
operator/controllers/keptntask/controller.go 57.30% <0.00%> (+3.37%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 51.31% <59.39%> (+1.23%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

mowies and others added 23 commits December 1, 2022 12:02
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies closed this Jan 9, 2023
@mowies mowies deleted the fix-linting-issues branch January 9, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter issues
2 participants