-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added podtato-head integration test scenario #486
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
===========================================
- Coverage 59.68% 48.78% -10.91%
===========================================
Files 28 55 +27
Lines 2101 5143 +3042
===========================================
+ Hits 1254 2509 +1255
- Misses 743 2527 +1784
- Partials 104 107 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
It would make sense to add at least one test where we won't have a positive outcome. For instance, we could test for an application where at least one workload is missing, and the application should not come up or fail. |
agree, will add another test case to this PR |
Signed-off-by: Florian Bacher <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! can we please create a ticket for the failed evaluation and test, that the remaining phases get cancelled ?
sure, here is the new issue: #512 |
Closes #321
Signed-off-by: Florian Bacher [email protected]