Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added podtato-head integration test scenario #486

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 30, 2022

Closes #321
Signed-off-by: Florian Bacher [email protected]

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #486 (66a462b) into main (ba6eadd) will decrease coverage by 10.90%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #486       +/-   ##
===========================================
- Coverage   59.68%   48.78%   -10.91%     
===========================================
  Files          28       55       +27     
  Lines        2101     5143     +3042     
===========================================
+ Hits         1254     2509     +1255     
- Misses        743     2527     +1784     
- Partials      104      107        +3     
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 77.31% <0.00%> (-1.55%) ⬇️
operator/controllers/common/evaluationhandler.go 78.07% <0.00%> (-0.57%) ⬇️
operator/api/v1alpha2/keptntaskdefinition_types.go 100.00% <0.00%> (ø)
operator/api/v1alpha2/keptntask_types.go 97.14% <0.00%> (ø)
operator/api/v1alpha2/keptnapp_types.go 91.66% <0.00%> (ø)
operator/api/v1alpha1/keptnapp_conversion.go 100.00% <0.00%> (ø)
...ator/api/v1alpha2/keptnevaluationprovider_types.go 100.00% <0.00%> (ø)
...erator/api/v1alpha2/keptnworkloadinstance_types.go 90.76% <0.00%> (ø)
operator/api/v1alpha2/keptnapp_webhook.go 0.00% <0.00%> (ø)
operator/api/v1alpha2/common/phases.go 100.00% <0.00%> (ø)
... and 19 more
Flag Coverage Δ
component-tests 50.88% <ø> (-0.20%) ⬇️
keptn-lifecycle-operator 47.27% <ø> (-9.38%) ⬇️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review December 12, 2022 08:35
@thschue
Copy link
Contributor

thschue commented Dec 12, 2022

It would make sense to add at least one test where we won't have a positive outcome. For instance, we could test for an application where at least one workload is missing, and the application should not come up or fail.

@bacherfl
Copy link
Member Author

It would make sense to add at least one test where we won't have a positive outcome. For instance, we could test for an application where at least one workload is missing, and the application should not come up or fail.

agree, will add another test case to this PR

Signed-off-by: Florian Bacher <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can we please create a ticket for the failed evaluation and test, that the remaining phases get cancelled ?

@bacherfl
Copy link
Member Author

lgtm! can we please create a ticket for the failed evaluation and test, that the remaining phases get cancelled ?

sure, here is the new issue: #512

@bacherfl bacherfl merged commit 58a91ed into keptn:main Dec 13, 2022
@bacherfl bacherfl deleted the feat/321/more-tests branch December 13, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: Cover a complex Integration test scenario
4 participants