Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pass locally built functions runner image to test setups #483

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 30, 2022

This PR should fix the failing integration tests on the release-please branches due to the missing functions runner image
Signed-off-by: Florian Bacher [email protected]

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #483 (032ab6b) into main (145a6ab) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   59.54%   59.63%   +0.09%     
==========================================
  Files          28       28              
  Lines        2101     2101              
==========================================
+ Hits         1251     1253       +2     
+ Misses        745      744       -1     
+ Partials      105      104       -1     
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 76.80% <0.00%> (-0.52%) ⬇️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 50.52% <ø> (-0.25%) ⬇️
keptn-lifecycle-operator 56.64% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title chore: pass locally built functions runner image to test setups ci: pass locally built functions runner image to test setups Nov 30, 2022
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacherfl bacherfl merged commit ba6eadd into keptn:main Nov 30, 2022
@bacherfl bacherfl deleted the fix/test-functions-runner-image branch November 30, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants