Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): rework Task and Evaluation span structure #465

Merged
merged 11 commits into from
Nov 25, 2022
Merged

feat(operator): rework Task and Evaluation span structure #465

merged 11 commits into from
Nov 25, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 24, 2022

Fixes: #411
Screenshot from 2022-11-23 16-08-47
Screenshot from 2022-11-23 16-10-54

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #465 (e4484e8) into main (247d026) will increase coverage by 7.72%.
The diff coverage is 60.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   43.77%   51.49%   +7.72%     
==========================================
  Files          27       28       +1     
  Lines        2136     2101      -35     
==========================================
+ Hits          935     1082     +147     
+ Misses       1115      920     -195     
- Partials       86       99      +13     
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 51.03% <0.00%> (ø)
...ptnworkloadinstance/reconcile_prepostdeployment.go 0.00% <0.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 0.00% <0.00%> (ø)
operator/controllers/common/evaluationhandler.go 72.64% <51.85%> (+72.64%) ⬆️
operator/controllers/common/taskhandler.go 75.43% <62.50%> (+75.43%) ⬆️
operator/controllers/common/spanitem.go 78.57% <78.57%> (ø)
operator/controllers/common/phasehandler.go 80.95% <84.61%> (+2.00%) ⬆️
operator/controllers/keptnappversion/controller.go 72.30% <90.00%> (ø)
operator/controllers/common/phaseitem.go 100.00% <100.00%> (+4.68%) ⬆️
operator/controllers/common/spanhandler.go 83.33% <100.00%> (ø)
... and 6 more
Flag Coverage Δ
keptn-lifecycle-operator 57.02% <60.29%> (+8.71%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review November 24, 2022 12:57
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
bacherfl
bacherfl previously approved these changes Nov 25, 2022
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT odubajDT requested a review from bacherfl November 25, 2022 09:43
@bacherfl bacherfl merged commit e5717c6 into keptn:main Nov 25, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Task/Evaluation Span structure
3 participants