ci: introduce additional linters for golangci-lint

.github/workflows/golangci-lint.yml

@@ -16,7 +16,7 @@ jobs:
           - name: "scheduler"
             folder: "scheduler/"
     steps:
-      - name: Check out code into the Go module directory
+      - name: Check out code
         uses: actions/checkout@v3
 
       - uses: actions/setup-go@v3

.golangci.yml

@@ -5,14 +5,17 @@ linters:
   enable:
     - gofmt         # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification
     - gci           # Gci controls golang package import order and makes it always deterministic.
-#    - errorlint       # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
-#    - containedctx  # containedctx is a linter that detects struct contained context.Context field
-#    - dogsled       # Checks assignments with too many blank identifiers (e.g. x, , , _, := f())
-#    - nilnil        # Checks that there is no simultaneous return of nil error and an invalid value.
-#    - noctx         # noctx finds sending http request without context.Context
+    - errorlint       # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
+    - containedctx  # containedctx is a linter that detects struct contained context.Context field
+    - dogsled       # Checks assignments with too many blank identifiers (e.g. x, , , _, := f())
+    - nilnil        # Checks that there is no simultaneous return of nil error and an invalid value.
+    - noctx         # noctx finds sending http request without context.Context
 
 issues:
   exclude-rules:
     - linters:
         - gci
       text: '//+kubebuilder'
+    - linters:
+        - containedctx
+      path: _test\.go

operator/controllers/keptnappversion/controller_test.go

@@ -136,6 +136,26 @@ func createFinishedAppVersionStatus() lfcv1alpha1.KeptnAppVersionStatus {
 	}
 }
 
+func setupReconcilerWithMeters(t *testing.T) *KeptnAppVersionReconciler {
+	//setup logger
+	opts := zap.Options{
+		Development: true,
+	}
+	ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
+
+	//fake a tracer
+	tr := &fake.ITracerMock{StartFunc: func(ctx context.Context, spanName string, opts ...trace.SpanStartOption) (context.Context, trace.Span) {
+		return ctx, trace.SpanFromContext(ctx)
+	}}
+
+	r := &KeptnAppVersionReconciler{
+		Log:    ctrl.Log.WithName("test-appVersionController"),
+		Tracer: tr,
+		Meters: utils.InitAppMeters(),
+	}
+	return r
+}
+
 func setupReconciler(t *testing.T) (*KeptnAppVersionReconciler, chan string, *fake.ITracerMock, *fake.SpanHandlerIMock) {
 	//setup logger
 	opts := zap.Options{
@@ -176,7 +196,7 @@ func setupReconciler(t *testing.T) (*KeptnAppVersionReconciler, chan string, *fa
 
 func TestKeptnApVersionReconciler_setupSpansContexts(t *testing.T) {
 
-	r, _, _, _ := setupReconciler(t)
+	r := setupReconcilerWithMeters(t)
 	type args struct {
 		ctx        context.Context
 		appVersion *lfcv1alpha1.KeptnAppVersion