-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): rework Workload and Application span structure #452
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 43.28% 43.77% +0.48%
==========================================
Files 27 27
Lines 2116 2136 +20
==========================================
+ Hits 916 935 +19
+ Misses 1118 1115 -3
- Partials 82 86 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
de7b0a0
to
8c1dee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the initial issue, the tasks and evaluations themselves should also be visible in the trace, which is missing in the current screenshot.
Task and evaluation spans restructuring will be handled in a separate PR, this PR restructures only workload and app spans, see the linked issues |
There is a separate issue for that: #411 |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
b152c1a
to
73747f4
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, good work!
Closes #409 #410