docs: fix CRD api version for EvaluationProvider and EvaluationDefinition #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```yaml > kubectl describe crd keptnevaluationdefinitions.lifecycle.keptn.sh Name: keptnevaluationdefinitions.lifecycle.keptn.sh Namespace: Labels: <none> Annotations: controller-gen.kubebuilder.io/version: v0.9.2 API Version: apiextensions.k8s.io/v1 Kind: CustomResourceDefinition ``` ```yaml > kubectl describe crd keptnevaluationproviders.lifecycle.keptn.sh Name: keptnevaluationproviders.lifecycle.keptn.sh Namespace: Labels: <none> Annotations: controller-gen.kubebuilder.io/version: v0.9.2 API Version: apiextensions.k8s.io/v1 Kind: CustomResourceDefinition ``` Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault
requested review from
thisthat,
thschue and
bacherfl
as code owners
thschue
changed the title
mowies
approved these changes
Nov 22, 2022
Signed-off-by: Moritz Wiesinger <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 37.99% 41.59% +3.60%
==========================================
Files 28 28
Lines 2082 2202 +120
==========================================
+ Hits 791 916 +125
+ Misses 1227 1204 -23
- Partials 64 82 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas Lamirault [email protected]