Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: have renovate update Makefile dependencies #431

Merged
merged 12 commits into from
Nov 17, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 17, 2022

This PR

  • moves the mlc_config file to the .github folder
  • adjusts the renovate configuration to allow it to update versions set in Makefiles (and any other files in the future if we need it)
  • updates are handled through special annotation comments in the following format:
# renovate: datasource=github-tags depName=kubernetes-sigs/kustomize
KUSTOMIZE_VERSION?=v4.2.0

datasource is set from a list of possible options that can be found here
depName points to the (usually) GitHub repo slug that releases the dependency in question

Wokring updates from renovate can be seen in my fork.
Fixes #314

mowies and others added 7 commits November 17, 2022 11:54
Signed-off-by: Moritz Wiesinger <[email protected]>

try to have github hostname in dep name

Signed-off-by: Moritz Wiesinger <[email protected]>

even more trying out

Signed-off-by: Moritz Wiesinger <[email protected]>

more trying out

Signed-off-by: Moritz Wiesinger <[email protected]>

try using hash for setup-envtest

Signed-off-by: Moritz Wiesinger <[email protected]>

adjust makefile matcher

Signed-off-by: Moritz Wiesinger <[email protected]>

try matching against github tags instead of releases

Signed-off-by: Moritz Wiesinger <[email protected]>

try specific matchers

Signed-off-by: Moritz Wiesinger <[email protected]>

try different file matcher

Signed-off-by: Moritz Wiesinger <[email protected]>

remove office hours setting

Signed-off-by: Moritz Wiesinger <[email protected]>

annotate examples

Signed-off-by: Moritz Wiesinger <[email protected]>

remove specific matchers

Signed-off-by: Moritz Wiesinger <[email protected]>

change file match

Signed-off-by: Moritz Wiesinger <[email protected]>

more annotations

Signed-off-by: Moritz Wiesinger <[email protected]>

allow whitespaces between the variable

Signed-off-by: Moritz Wiesinger <[email protected]>

add more renovate annotation comments

Signed-off-by: Moritz Wiesinger <[email protected]>

fix renovate config

Signed-off-by: Moritz Wiesinger <[email protected]>

try to fix renovate config

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>

remove line starts and ends

Signed-off-by: Moritz Wiesinger <[email protected]>

debugging

Signed-off-by: Moritz Wiesinger <[email protected]>

debugging

Signed-off-by: Moritz Wiesinger <[email protected]>

debugging

Signed-off-by: Moritz Wiesinger <[email protected]>

try different multi line matching

Signed-off-by: Moritz Wiesinger <[email protected]>

one more try

Signed-off-by: Moritz Wiesinger <[email protected]>

another try

Signed-off-by: Moritz Wiesinger <[email protected]>

try another version

Signed-off-by: Moritz Wiesinger <[email protected]>

add versioning setting

Signed-off-by: Moritz Wiesinger <[email protected]>

set setup-envtest version differently

Signed-off-by: Moritz Wiesinger <[email protected]>

try adding the package name separately

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>

try to go back to matching in a single line

Signed-off-by: Moritz Wiesinger <[email protected]>

update k8s controller tools with renovate

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the renovate-customizations branch from a26f4b3 to cddf9f2 Compare November 17, 2022 10:54
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #431 (926a185) into main (3afcaad) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   28.36%   28.36%           
=======================================
  Files          16       16           
  Lines        1484     1484           
=======================================
  Hits          421      421           
  Misses       1040     1040           
  Partials       23       23           
Flag Coverage Δ
keptn-lifecycle-operator 32.54% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link
Contributor

@philipp-hinteregger philipp-hinteregger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
bacherfl
bacherfl previously approved these changes Nov 17, 2022
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies dismissed stale reviews from philipp-hinteregger and bacherfl via 926a185 November 17, 2022 14:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 2ad37e9 into keptn:main Nov 17, 2022
@mowies mowies deleted the renovate-customizations branch November 17, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Renovate update Makefile versions as well
3 participants