Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Changed checks on pod owner replicas #412

Merged
merged 9 commits into from
Nov 15, 2022

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Nov 14, 2022

This PR fixes #379 :

  • In case the pod is under a replica set or a stateful set we should check that the available replicas correspond to the wanted replicas, not try to retrieve the deployment
  • adds tests
  • refactor namespace usage in kuttl tests

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #412 (d61a3a6) into main (df346f7) will increase coverage by 1.29%.
The diff coverage is 69.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   26.15%   27.44%   +1.29%     
==========================================
  Files          16       16              
  Lines        1495     1483      -12     
==========================================
+ Hits          391      407      +16     
+ Misses       1086     1056      -30     
- Partials       18       20       +2     
Impacted Files Coverage Δ
operator/webhooks/pod_mutating_webhook.go 36.22% <0.00%> (ø)
...keptnworkloadinstance/reconcile_deploymentstate.go 40.00% <72.72%> (+28.88%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 31.45% <69.56%> (+1.55%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

kuttl-test.yaml Outdated Show resolved Hide resolved
@bacherfl bacherfl merged commit 46524a7 into main Nov 15, 2022
@bacherfl bacherfl deleted the fix/s79/wi_should_check_replicaset_owner branch November 15, 2022 08:46
@keptn-bot keptn-bot mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong reference for replica-set
3 participants