Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): cancel pending phases when evaluation fails #408

Merged
merged 14 commits into from
Nov 18, 2022
Merged

fix(operator): cancel pending phases when evaluation fails #408

merged 14 commits into from
Nov 18, 2022

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

Fixes: #381

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #408 (71a9cbc) into main (246f0b6) will increase coverage by 3.71%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   28.36%   32.08%   +3.71%     
==========================================
  Files          16       16              
  Lines        1484     1490       +6     
==========================================
+ Hits          421      478      +57     
+ Misses       1040      985      -55     
- Partials       23       27       +4     
Impacted Files Coverage Δ
operator/controllers/common/interfaces.go 100.00% <100.00%> (ø)
operator/controllers/common/phasehandler.go 77.61% <100.00%> (+77.61%) ⬆️
operator/controllers/common/spanhandler.go 78.57% <0.00%> (+10.71%) ⬆️
Flag Coverage Δ
keptn-lifecycle-operator 36.87% <100.00%> (+4.33%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review November 15, 2022 12:18
thschue
thschue previously approved these changes Nov 15, 2022
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bacherfl
bacherfl previously approved these changes Nov 16, 2022
@odubajDT odubajDT dismissed stale reviews from bacherfl and thschue via ba5c2cf November 16, 2022 10:31
bacherfl
bacherfl previously approved these changes Nov 16, 2022
@odubajDT odubajDT changed the title fix(operator): Cancel pending phases when evaluation fails fix(operator): cancel pending phases when evaluation fails Nov 17, 2022
@odubajDT odubajDT requested a review from thschue November 17, 2022 06:32
@odubajDT odubajDT requested a review from bacherfl November 17, 2022 06:32
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
14.6% 14.6% Duplication

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 7f15baf into keptn:main Nov 18, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure state should always be propagated
3 participants