chore: remove waiting after KEDA integration test cleanup #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3836 +/- ##
==========================================
- Coverage 77.72% 77.70% -0.03%
==========================================
Files 219 219
Lines 11575 11575
==========================================
- Hits 8997 8994 -3
- Misses 2214 2216 +2
- Partials 364 365 +1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
fix-keda-test
branch
from
1baf489 to
96736d2
Compare
odubajDT
changed the title
|
mowies
approved these changes
Nov 5, 2024
bacherfl
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no need to wait for cleanup of KEDA resources (which takes time+resources and often times out) after KEDA integration test as the cluster will be deleted after the test is finished even if the uninstallation is not done yet.