Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Kubernetes v1.31 #3785

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

odubajDT
Copy link
Contributor

Fixes #3783

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.65%. Comparing base (9e742e8) to head (1bd2322).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3785      +/-   ##
==========================================
- Coverage   76.66%   76.65%   -0.01%     
==========================================
  Files         224      224              
  Lines       11875    11883       +8     
==========================================
+ Hits         9104     9109       +5     
- Misses       2402     2404       +2     
- Partials      369      370       +1     
Files with missing lines Coverage Δ
...rator/controllers/lifecycle/keptntask/job_utils.go 67.96% <100.00%> (+2.13%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 47.44% <ø> (ø)
component-tests 79.21% <100.00%> (+21.63%) ⬆️
lifecycle-operator 79.69% <100.00%> (+0.02%) ⬆️
metrics-operator 75.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the fix-task-job-condition branch from 88083a7 to 2fb3fed Compare October 29, 2024 13:20
@github-actions github-actions bot added the ops label Oct 29, 2024
@odubajDT odubajDT marked this pull request as ready for review October 29, 2024 13:21
@odubajDT odubajDT requested a review from a team as a code owner October 29, 2024 13:21
mowies
mowies previously approved these changes Oct 29, 2024
@odubajDT odubajDT changed the title fix(lifecycle-operator): improve Job status checks in KeptnTaskReconciler feat: support K8s 1.31 Oct 29, 2024
@odubajDT odubajDT changed the title feat: support K8s 1.31 feat: support K8s v1.31 Oct 29, 2024
@mowies mowies changed the title feat: support K8s v1.31 feat: add support for Kubernetes v1.31 Oct 29, 2024
bacherfl
bacherfl previously approved these changes Oct 29, 2024
Copy link

@odubajDT odubajDT merged commit 2c5ba22 into main Oct 29, 2024
37 of 38 checks passed
@odubajDT odubajDT deleted the fix-task-job-condition branch October 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job status verification does not work with k8s 1.30+
3 participants