Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix KeptnMetric in metrics example #3667

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 6, 2024

for some reason, the keptnmetric doesn't work with the keptn provided range options

@mowies mowies requested a review from a team as a code owner August 6, 2024 14:19
Copy link

sonarqubecloud bot commented Aug 6, 2024

@mowies mowies requested review from bacherfl and odubajDT August 6, 2024 14:21
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.71%. Comparing base (ff62ede) to head (19fcf93).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3667      +/-   ##
==========================================
+ Coverage   74.67%   74.71%   +0.03%     
==========================================
  Files         225      225              
  Lines       10131    10131              
==========================================
+ Hits         7565     7569       +4     
+ Misses       2196     2193       -3     
+ Partials      370      369       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 47.20% <ø> (ø)
component-tests 58.36% <ø> (+0.32%) ⬆️
lifecycle-operator 76.22% <ø> (ø)
metrics-operator 76.17% <ø> (ø)
scheduler 34.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT merged commit 504f4af into keptn:main Aug 7, 2024
35 checks passed
@mowies mowies deleted the fix-example-metric branch August 7, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants