Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added container section #3580

Merged
merged 5 commits into from
Jul 4, 2024
Merged

docs: added container section #3580

merged 5 commits into from
Jul 4, 2024

Conversation

BalaadityaPatanjali
Copy link
Contributor

Fixes #3097

  • added the container section in technologies.md

@BalaadityaPatanjali
removed the note from slo.md
18ce507 
Signed-off-by: BalaadityaPatanjali <[email protected]>
@BalaadityaPatanjali
Added the containers section
d610298 
Signed-off-by: BalaadityaPatanjali <[email protected]>
@BalaadityaPatanjali BalaadityaPatanjali requested review from a team as code owners July 2, 2024 16:46
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 2, 2024
@RealAnna
Copy link
Contributor

RealAnna commented Jul 3, 2024

Hi @BalaadityaPatanjali thanks fr the contribution! Please check the pipeline here to see what links are not working

@BalaadityaPatanjali
Copy link
Contributor Author

Hi @BalaadityaPatanjali thanks fr the contribution! Please check the pipeline here to see what links are not working

Markdown-link-check is failing because in docs/docs/guides/otel.md , link for setup of monitoring other namespaces is not working and i am not familiar with that at all. So, i don't think i should replace that link. A little guidance here would be appreciated.

@mowies
Copy link
Member

mowies commented Jul 4, 2024

@BalaadityaPatanjali that dead link was apparently moved to https://prometheus-operator.dev/kube-prometheus/kube/monitoring-other-namespaces/
Could you please update it as part of this PR?

@BalaadityaPatanjali
Copy link
Contributor Author

@BalaadityaPatanjali that dead link was apparently moved to https://prometheus-operator.dev/kube-prometheus/kube/monitoring-other-namespaces/ Could you please update it as part of this PR?

I have updated the link. Please have a look at it.

RealAnna
RealAnna approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🚀

@RealAnna RealAnna merged commit b45e2f3 into keptn:main Jul 4, 2024
9 checks passed
@keptn-bot keptn-bot mentioned this pull request Jul 4, 2024
Merged
@BalaadityaPatanjali
Copy link
Contributor Author

Thank you for the contribution! 🚀

Thank you for the merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance contrib guide technologies section with beginner friendly containers and k8s resources
3 participants
@BalaadityaPatanjali @RealAnna @mowies