chore(lifecycle-operator): revert unused ObservabilityTimeout parameter from KeptnWorkload #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er from KeptnWorkload Signed-off-by: odubajDT <[email protected]>
github-actions
bot
added
documentation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3163 +/- ##
==========================================
+ Coverage 86.82% 86.83% +0.01%
==========================================
Files 162 162
Lines 8605 8605
==========================================
+ Hits 7471 7472 +1
+ Misses 843 842 -1
Partials 291 291
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
approved these changes
Mar 4, 2024
thisthat
approved these changes
Mar 4, 2024
This was referenced Mar 4, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…er from KeptnWorkload (keptn#3163) Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #3153
Part-of: #3134
Reason: parameter is not needed for the implementation of the ObservabilityTimeout, see here #3160