Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): adapt KeptnConfig reconciler to set up observabilityTimeout parameter #3154

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

odubajDT
Copy link
Contributor

part-of: #3134

Depends on: #3149

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (de077c7) to head (5887ed8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   86.84%   86.83%   -0.02%     
==========================================
  Files         162      162              
  Lines        8597     8605       +8     
==========================================
+ Hits         7466     7472       +6     
- Misses        841      842       +1     
- Partials      290      291       +1     
Files Coverage Δ
...cycle-operator/controllers/common/config/config.go 100.00% <100.00%> (ø)
...ator/controllers/options/keptnconfig_controller.go 84.61% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.13% <ø> (-0.77%) ⬇️
lifecycle-operator 86.48% <100.00%> (+0.01%) ⬆️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

odubajDT added 2 commits March 1, 2024 09:10
Signed-off-by: odubajDT <[email protected]>
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT marked this pull request as ready for review March 1, 2024 08:21
@odubajDT odubajDT requested a review from a team as a code owner March 1, 2024 08:21
@odubajDT odubajDT merged commit f14a1ff into keptn:main Mar 1, 2024
33 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…rvabilityTimeout parameter (keptn#3154)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants