fix(lifecycle-operator): retrieve KeptnEvaluationDefinition before creating KeptnEvaluation

[odubajDT]

Changes

• fix the issue in evaluationHandler, where only KeptnEvaluationDefinition name was propagated to the created evaluation -> the whole EvaluationDefinition should be propagated
• change behavior of the phase state to display Pending instead of Unknown when Definition is not found
• regression unit tests
• add integration tests
• polish integration tests

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (ce57993) to head (e9c1f4b).
Report is 96 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
+ Coverage   85.75%   86.77%   +1.02%     
==========================================
  Files         162      162              
  Lines       10351     8607    -1744     
==========================================
- Hits         8876     7469    -1407     
+ Misses       1186      846     -340     
- Partials      289      292       +3     

Files	Coverage Δ
...e-operator/apis/lifecycle/v1beta1/common/common.go	100.00% <100.00%> (ø)
...-operator/controllers/common/evaluation/handler.go	79.10% <61.11%> (+1.09%)	⬆️

... and 137 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	69.23% <ø> (+1.80%)	⬆️
component-tests	55.95% <ø> (-0.05%)	⬇️
keptn-lifecycle-operator	?
lifecycle-operator	86.40% <66.66%> (+1.11%)	⬆️
metrics-operator	88.32% <ø> (+0.68%)	⬆️
scheduler	34.74% <ø> (-1.79%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[RealAnna]

will you have a separate PR for Tasks? I thought we also have this Unknown state for that controller 🤔

[odubajDT]

will you have a separate PR for Tasks? I thought we also have this Unknown state for that controller 🤔

No for the tasks it works. I added an integration test to confirm it. No code changes needed there. See here the adapted test for example https://github.com/keptn/lifecycle-toolkit/pull/3144/files#diff-2cf9722b1b36ffc6e553da4aa607e485d9e80f6a8550f170fbeba180ee8bf4f8R10

[RealAnna]

will you have a separate PR for Tasks? I thought we also have this Unknown state for that controller 🤔

No for the tasks it works. I added an integration test to confirm it. No code changes needed there. See here the adapted test for example #3144 (files)

Have not checked the task code but I am confused, wasn't that test already passing with Unknown? Doesn't that mean that the state is initially Pending by default and then changed to Unkown when the task definition is not found? So the current integration test just exits immediately before the state is changed to unknown?