Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): add feature flag for enabling promotion tasks #3055

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

bacherfl
Copy link
Member

Closes #3035

@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce57993) 85.75% compared to head (0fa1aa8) 86.82%.
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
+ Coverage   85.75%   86.82%   +1.07%     
==========================================
  Files         162      162              
  Lines       10351     8514    -1837     
==========================================
- Hits         8876     7392    -1484     
+ Misses       1186      834     -352     
+ Partials      289      288       -1     

see 139 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (+1.80%) ⬆️
component-tests 57.47% <ø> (+1.47%) ⬆️
keptn-lifecycle-operator ?
lifecycle-operator 86.39% <ø> (+1.10%) ⬆️
metrics-operator 88.32% <ø> (+0.68%) ⬆️
scheduler 34.74% <ø> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review February 15, 2024 08:50
@bacherfl bacherfl requested a review from a team as a code owner February 15, 2024 08:50
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bacherfl bacherfl merged commit d4044c1 into keptn:main Feb 15, 2024
42 checks passed
@bacherfl bacherfl deleted the feat/3035/promotion-task-feature-flag branch February 15, 2024 09:08
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Helm feature flag for promotion feature
3 participants