Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix formatting in CRD reference pages #2954

Merged
merged 2 commits into from
Feb 5, 2024
Merged

docs: fix formatting in CRD reference pages #2954

merged 2 commits into from
Feb 5, 2024

Conversation

StackScribe
Copy link
Contributor

This PR:

  • Fixes formatting issues for "Fields" sections on the KeptnMetricsProvider, KeptnMetric, and KeptnEvaluationDefinition ref pages
  • Also add mention of AnalysisValueTemplate to KeptnMetricsProvider descriptive text and "See also"

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Feb 5, 2024
@StackScribe StackScribe added this to the 0.10 milestone Feb 5, 2024
@StackScribe StackScribe self-assigned this Feb 5, 2024
@StackScribe StackScribe requested review from a team as code owners February 5, 2024 09:07
@mowies mowies changed the title docs: fix format for KeptnMetricsProvider, KeptnMetric, KeptnEvaluati… docs: fix formatting in CRD reference pages Feb 5, 2024
RealAnna
RealAnna previously approved these changes Feb 5, 2024
View reviewed changes
@StackScribe
re-enable checks
8c4ee5a 
Signed-off-by: Meg McRoberts <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@StackScribe StackScribe merged commit 634e055 into main Feb 5, 2024
10 checks passed
@StackScribe StackScribe deleted the 0204-metric-format branch February 5, 2024 13:16
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
@StackScribe @Bharadwajshivam28
docs: fix formatting in CRD reference pages (keptn#2954)
266f035 
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: shivam <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@StackScribe @Vickysomtee
docs: fix formatting in CRD reference pages (keptn#2954)
4270d44 
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@StackScribe @mowies @RealAnna