-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document how to write create new keptnmetricsprovider #2939
docs: document how to write create new keptnmetricsprovider #2939
Conversation
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
+ Coverage 85.75% 86.77% +1.02%
==========================================
Files 162 162
Lines 10351 8514 -1837
==========================================
- Hits 8876 7388 -1488
+ Misses 1186 837 -349
Partials 289 289 see 139 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thanks for taking this on -- it's an important piece of doc that we really need!
Any idea why the doc file is not showing in the readthedocs preview?
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Geoffrey Israel <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Geoffrey Israel <[email protected]>
No idea yet but i will look into it. |
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330 this is great! Could you please rebase and fix the conflicts? I think we are good to merge |
…ptnmetricsprovider
Done |
Co-authored-by: odubajDT <[email protected]> Signed-off-by: Geoffrey Israel <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Quality Gate passedIssues Measures |
Signed-off-by: Geoffrey Israel <[email protected]> Signed-off-by: odubajDT <[email protected]> Co-authored-by: Meg McRoberts <[email protected]> Co-authored-by: RealAnna <[email protected]> Co-authored-by: odubajDT <[email protected]> Signed-off-by: shivam <[email protected]>
Signed-off-by: Geoffrey Israel <[email protected]> Signed-off-by: odubajDT <[email protected]> Co-authored-by: Meg McRoberts <[email protected]> Co-authored-by: RealAnna <[email protected]> Co-authored-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Fixes #1248
Description
This PR documents the process for creating a new
KeptnMetricsProvider
within Keptn. It provides detailed instructions on defining a new provider type, implementing the provider, and instantiating it within the Keptn environment. Additionally, it covers the necessary updates tovalidation webhooks
, CRD configs, and Helm charts to ensure seamless integration of the new provider.Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview