Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix HTMLTest HTTP 429 issues #2938

Merged
merged 3 commits into from
Feb 5, 2024
Merged

ci: fix HTMLTest HTTP 429 issues #2938

merged 3 commits into from
Feb 5, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Feb 1, 2024

This PR

  • removes the docs/tmp/.htmltest path from the github cache since it's not needed anymore because of the recent docs tooling changes
  • changes the cache key so that it includes a hash of the refcache.json file which stores external URLs checks from HTMLTest. This should fix recent HTTP 429 issues when new external links were added to the docs

@mowies mowies requested a review from a team as a code owner February 1, 2024 12:03
@mowies mowies changed the title remove path that's not used anymore since introduction of the new doc… ci: fix HTMLTest HTTP 429 issues Feb 1, 2024
@github-actions github-actions bot added the ops label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9095a00) 85.82% compared to head (c8412b9) 85.85%.
Report is 2 commits behind head on main.

❗ Current head c8412b9 differs from pull request most recent head 01b9410. Consider uploading reports for the commit 01b9410 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
+ Coverage   85.82%   85.85%   +0.02%     
==========================================
  Files         161      161              
  Lines       10252    10252              
==========================================
+ Hits         8799     8802       +3     
+ Misses       1170     1168       -2     
+ Partials      283      282       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.82% <ø> (+0.73%) ⬆️
lifecycle-operator 84.88% <ø> (ø)
metrics-operator 87.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mowies mowies merged commit 43259c4 into keptn:main Feb 5, 2024
32 checks passed
@mowies mowies deleted the fix-htmltest branch February 5, 2024 07:34
bacherfl pushed a commit to bacherfl/lifecycle-controller that referenced this pull request Feb 5, 2024
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants