Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add KeptnAppContext ref page; update KeptnApp ref page #2894

Merged
merged 42 commits into from
Feb 2, 2024
Merged

docs: add KeptnAppContext ref page; update KeptnApp ref page #2894

merged 42 commits into from
Feb 2, 2024

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Jan 29, 2024 •
edited by mowies
Loading

Summary

  • Create KeptnAppContext ref page
  • Update KeptnApp ref page to v1beta1 syntax

Fixes #2836

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • [n/a] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jan 29, 2024
@StackScribe StackScribe added this to the 0.11 milestone Jan 29, 2024
@StackScribe StackScribe self-assigned this Jan 29, 2024
@StackScribe StackScribe requested review from a team as code owners January 29, 2024 07:16
@StackScribe StackScribe mentioned this pull request Jan 29, 2024
Merged
@StackScribe
kibernetes, xrefs
67faf1a 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe marked this pull request as draft January 29, 2024 09:32
@StackScribe
markdown lint fixes
fecab27 
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe and others added 6 commits January 29, 2024 19:07
@StackScribe @odubajDT
Update docs/docs/reference/crd-reference/app.md
914f550 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/docs/reference/crd-reference/app.md
226f3e0 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
ondrej comments
2b59107 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
Merge branch '0125-context-ref' of github.com:keptn/lifecycle-toolkit…
c12436a 
… into 0125-context-ref

Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
indentation/content for KeptnApp field descriptions
ac09050 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
description for KeptnAppContext
57957c8 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
custom attributes
4b0d21a 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe marked this pull request as ready for review January 31, 2024 08:31
@StackScribe
markdownlint-fix
9fae383 
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe and others added 16 commits February 1, 2024 03:11
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
7e0fe4e 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
d42c245 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
3e34014 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
e71e945 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
0ad7103 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/app.md
c12b2b2 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
fix KeptnAppContext initial descripion
7d36131 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
9fcd81e 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
409a8d9 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
7c32308 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
bcf9324 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
eb05bd3 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
markdownlint-fix
81a539b 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
Merge branch '0125-context-ref' of github.com:keptn/lifecycle-toolkit…
ec93c20 
… into 0125-context-ref

Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
markdownlint-fix
7183e75 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
no custom labels in app.md
a985fdd 
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe and others added 2 commits February 1, 2024 17:37
@StackScribe @mowies
Update docs/docs/reference/crd-reference/appcontext.md
b742cf1 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
protect Field info from markdownlint-fix
bf035dc 
Signed-off-by: Meg McRoberts <[email protected]>
RealAnna
RealAnna previously approved these changes Feb 2, 2024
View reviewed changes
@StackScribe @bacherfl
Update docs/docs/reference/crd-reference/appcontext.md
6dcdc17 
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@StackScribe StackScribe merged commit 43c2ccb into main Feb 2, 2024
11 checks passed
@StackScribe StackScribe deleted the 0125-context-ref branch February 2, 2024 08:50
bacherfl added a commit to bacherfl/lifecycle-controller that referenced this pull request Feb 5, 2024
@StackScribe @odubajDT
@bacherfl @mowies
docs: add KeptnAppContext ref page; update KeptnApp ref page (keptn#2894
eea908f 
)

Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@StackScribe @odubajDT
@bacherfl @mowies @Vickysomtee
docs: add KeptnAppContext ref page; update KeptnApp ref page (keptn#2894
77c6dd6 
)

Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT left review comments

@mowies mowies mowies left review comments

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

CRD reference page for KeptnAppContext
5 participants
@StackScribe @bacherfl @mowies @RealAnna @odubajDT