Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable chainsaw integration tests #2882

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

eddycharly
Copy link
Contributor

@eddycharly eddycharly commented Jan 25, 2024

This PR adds chainsaw e2e tests:

  • allowed namespaces
  • scheduling gates

Those tests are equivalent to kuttl ones, they have been converted using the chainsaw migration command and adapted manually to use declarative syntax instead of relying on bash scripts.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7ee4fb) 85.87% compared to head (0385bd1) 85.18%.

❗ Current head 0385bd1 differs from pull request most recent head 3d40563. Consider uploading reports for the commit 3d40563 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   85.87%   85.18%   -0.69%     
==========================================
  Files         161      120      -41     
  Lines       10252     7461    -2791     
==========================================
- Hits         8804     6356    -2448     
+ Misses       1166      904     -262     
+ Partials      282      201      -81     

see 43 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.82% <ø> (+0.40%) ⬆️
lifecycle-operator 84.88% <ø> (ø)
metrics-operator ?
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@eddycharly eddycharly force-pushed the chainsaw-migrate branch 3 times, most recently from e342b58 to 17db840 Compare January 26, 2024 09:19
@github-actions github-actions bot added the ops label Jan 26, 2024
@eddycharly eddycharly force-pushed the chainsaw-migrate branch 3 times, most recently from 9ed859e to 8fc103f Compare January 26, 2024 09:45
.chainsaw.yaml Outdated Show resolved Hide resolved
@eddycharly eddycharly force-pushed the chainsaw-migrate branch 8 times, most recently from b7fa0cf to 8d7e679 Compare January 26, 2024 13:27
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly eddycharly changed the title chore: migrate e2e tests from kuttl to chainsaw chore: enable chainsaw e2e tests Jan 26, 2024
@eddycharly eddycharly marked this pull request as ready for review January 26, 2024 17:02
@eddycharly eddycharly requested a review from a team as a code owner January 26, 2024 17:02
@eddycharly eddycharly force-pushed the chainsaw-migrate branch 4 times, most recently from f70b37a to c8a0728 Compare January 31, 2024 01:18
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly eddycharly requested a review from a team as a code owner January 31, 2024 01:18
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 31, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@eddycharly eddycharly changed the title chore: enable chainsaw e2e tests chore: enable chainsaw integration tests Jan 31, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@RealAnna
Copy link
Contributor

RealAnna commented Jan 31, 2024

link error fixed in #2918

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bacherfl bacherfl merged commit 66ae056 into keptn:main Feb 1, 2024
36 checks passed
bacherfl pushed a commit to bacherfl/lifecycle-controller that referenced this pull request Feb 5, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants