Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove some folders from release-please monorepo setup #2834

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 18, 2024

Description

This PR tries to fix some of the release issues currently occurring.
It removes some of the root-level folder from being picked up by release-please. This should ensure that when e.g. an integration test is changed or added as part of an operator feature, that won't show up in the keptn-overall changelog. Same with spelling issues and examples.

Part of #2812

@mowies mowies requested a review from a team as a code owner January 18, 2024 10:55
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0b1942) 85.69% compared to head (80c62d8) 85.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   85.69%   85.66%   -0.03%     
==========================================
  Files         160      160              
  Lines       10140    10140              
==========================================
- Hits         8689     8686       -3     
- Misses       1171     1173       +2     
- Partials      280      281       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.25% <ø> (-0.97%) ⬇️
lifecycle-operator 84.62% <ø> (ø)
metrics-operator 87.65% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title ci: remove some folder from release-please monorepo setup ci: remove some folders from release-please monorepo setup Jan 18, 2024
@mowies mowies merged commit fecf56b into keptn:main Jan 18, 2024
30 checks passed
@mowies mowies deleted the release-fixes branch January 18, 2024 11:59
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants