Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): support linked spans in KeptnAppVersion #2833

Merged
merged 7 commits into from
Jan 23, 2024
Merged

feat(lifecycle-operator): support linked spans in KeptnAppVersion #2833

merged 7 commits into from
Jan 23, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #2577

@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f700ce) 85.70% compared to head (e42df45) 85.75%.

❗ Current head e42df45 differs from pull request most recent head f4265fa. Consider uploading reports for the commit f4265fa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2833      +/-   ##
==========================================
+ Coverage   85.70%   85.75%   +0.04%     
==========================================
  Files         161      161              
  Lines       10202    10234      +32     
==========================================
+ Hits         8744     8776      +32     
  Misses       1175     1175              
  Partials      283      283              
Files Coverage Δ
...or/apis/lifecycle/v1beta1/keptnappcontext_types.go 100.00% <ø> (ø)
...or/apis/lifecycle/v1beta1/keptnappversion_types.go 97.68% <ø> (ø)
...erator/controllers/common/telemetry/spanhandler.go 88.00% <100.00%> (+1.33%) ⬆️
...rator/controllers/lifecycle/keptnapp/controller.go 58.00% <100.00%> (ø)
...ontrollers/lifecycle/keptnappversion/controller.go 78.32% <100.00%> (+5.04%) ⬆️
Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
lifecycle-operator 84.76% <100.00%> (+0.07%) ⬆️
metrics-operator 87.63% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review January 19, 2024 09:59
@odubajDT odubajDT requested review from a team as code owners January 19, 2024 09:59
@bacherfl
Copy link
Member

awesome work, just had some minor comments on naming in the code, but other than that it seems to work as expected:

Screenshot 2024-01-19 at 12 22 16

@odubajDT odubajDT requested a review from bacherfl January 19, 2024 11:57
bacherfl
bacherfl previously approved these changes Jan 19, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 36e19b2 into keptn:main Jan 23, 2024
41 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for linked traces for KeptnAppVersion
5 participants