Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove old docs folder and replace with new one #2816

Closed
wants to merge 5 commits into from

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 16, 2024

Description

This PR move the docs-new to the docs folder and deletes the old docs folder.
It also fixes all other occurrences of docs-new and changes them to docs.

Notes

Please review commit by commit to reduce confusion with seemingly moved files!

Fixes #2774

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies requested review from a team as code owners January 16, 2024 13:26
@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Jan 16, 2024
@mowies mowies changed the title remove old docs folder docs: remove old docs folder and replace with new one Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1330ee) 85.75% compared to head (792f620) 85.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2816      +/-   ##
==========================================
- Coverage   85.75%   85.72%   -0.03%     
==========================================
  Files         160      160              
  Lines       10164    10164              
==========================================
- Hits         8716     8713       -3     
- Misses       1169     1171       +2     
- Partials      279      280       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.36% <ø> (-0.77%) ⬇️
lifecycle-operator 84.72% <ø> (ø)
metrics-operator 87.65% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the docs-finalization branch from 6e9daa2 to 792f620 Compare January 16, 2024 14:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is the plan vis-a-vis this PR and #2705 ? I would hope that we would merge that with the docs-new references as well as any viable open docs PRs before we merge this, then will need to make another pass at the contrib guide to replace "docs-new" with "docs" but please confirm.

@mowies
Copy link
Member Author

mowies commented Jan 17, 2024

@StackScribe if we merge this one first, I can go ahead and fix the contrib guide in my other PR directly :)

@StackScribe
Copy link
Contributor

I would prefer that we go ahead and merge the other PR and then do a separate PR for the docs-new -> docs change -- and I could do that. But please, let's try to get as many PRs merged as possible before we merge this one! We will probably have some that aren't ready and will have to be modified later but let's minimize that effort as much as possible!

@mowies
Copy link
Member Author

mowies commented Jan 17, 2024

superseded by #2825

@mowies mowies closed this Jan 17, 2024
@mowies mowies deleted the docs-finalization branch January 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing here all new website setup actions I could not find in the backlog
3 participants