-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove old docs folder and replace with new one #2816
Conversation
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 85.75% 85.72% -0.03%
==========================================
Files 160 160
Lines 10164 10164
==========================================
- Hits 8716 8713 -3
- Misses 1169 1171 +2
- Partials 279 280 +1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
6e9daa2
to
792f620
Compare
Quality Gate failedFailed conditions C Reliability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what is the plan vis-a-vis this PR and #2705 ? I would hope that we would merge that with the docs-new references as well as any viable open docs PRs before we merge this, then will need to make another pass at the contrib guide to replace "docs-new" with "docs" but please confirm.
@StackScribe if we merge this one first, I can go ahead and fix the contrib guide in my other PR directly :) |
I would prefer that we go ahead and merge the other PR and then do a separate PR for the docs-new -> docs change -- and I could do that. But please, let's try to get as many PRs merged as possible before we merge this one! We will probably have some that aren't ready and will have to be modified later but let's minimize that effort as much as possible! |
superseded by #2825 |
Description
This PR move the
docs-new
to thedocs
folder and deletes the olddocs
folder.It also fixes all other occurrences of
docs-new
and changes them todocs
.Notes
Please review commit by commit to reduce confusion with seemingly moved files!
Fixes #2774