-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global value for imagePullPolicy #2807
feat: add global value for imagePullPolicy #2807
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2807 +/- ##
==========================================
+ Coverage 85.75% 86.77% +1.02%
==========================================
Files 162 162
Lines 10351 8554 -1797
==========================================
- Hits 8876 7423 -1453
+ Misses 1186 841 -345
- Partials 289 290 +1 see 139 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
@prakrit55 I updated all helm charts to the new common chart version that includes your changes: #2831 |
@prakrit55 please regenerate the helm chart documentation using the script under .github/scripts folder |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
ahh yess, forgot that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the more specific imagePullPolicy for the component should take precedence over the globally set value. In the current setup the global one takes precedence
In that case, I thing we need to change Creating another pr in the |
need to verify why the values order is not respected
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: RealAnna <[email protected]>
781665b
to
b5775d0
Compare
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Quality Gate passedIssues Measures |
Signed-off-by: Griffin <[email protected]> Signed-off-by: RealAnna <[email protected]> Co-authored-by: RealAnna <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Description
imagePullPolicy
can be used in main chart which will supersede the sub charts_helpers.tpl
has been adaptedFixes #2362
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview