Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global value for imagePullPolicy #2807

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

prakrit55
Copy link
Member

Description

  • imagePullPolicy can be used in main chart which will supersede the sub charts
  • _helpers.tpl has been adapted
  • global value is referenced in all subcharts
  • tests are adjusted to verify that the new global value works

Fixes #2362

How to test

Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.

  • Manual Test A
  • Unit Test B
  • Integration Test C

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Summary

Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@prakrit55 prakrit55 requested a review from a team as a code owner January 15, 2024 15:48
@prakrit55 prakrit55 changed the title chart: add global value for imagePullPolicy feat: add global value for imagePullPolicy Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce57993) 85.75% compared to head (a2e9a03) 86.77%.
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
+ Coverage   85.75%   86.77%   +1.02%     
==========================================
  Files         162      162              
  Lines       10351     8554    -1797     
==========================================
- Hits         8876     7423    -1453     
+ Misses       1186      841     -345     
- Partials      289      290       +1     

see 139 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (+1.80%) ⬆️
component-tests 56.64% <ø> (+0.64%) ⬆️
keptn-lifecycle-operator ?
lifecycle-operator 86.40% <ø> (+1.11%) ⬆️
metrics-operator 88.32% <ø> (+0.68%) ⬆️
scheduler 34.74% <ø> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 16, 2024
@mowies
Copy link
Member

mowies commented Jan 18, 2024

@prakrit55 I updated all helm charts to the new common chart version that includes your changes: #2831

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 18, 2024
@RealAnna
Copy link
Contributor

@prakrit55 please regenerate the helm chart documentation using the script under .github/scripts folder

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prakrit55
Copy link
Member Author

@prakrit55 please regenerate the helm chart documentation using the script under .github/scripts folder

ahh yess, forgot that

RealAnna
RealAnna previously approved these changes Jan 25, 2024
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the more specific imagePullPolicy for the component should take precedence over the globally set value. In the current setup the global one takes precedence

@prakrit55
Copy link
Member Author

prakrit55 commented Jan 25, 2024

I think the more specific imagePullPolicy for the component should take precedence over the globally set value. In the current setup the global one takes precedence

In that case, I thing we need to change
https://github.com/keptn/lifecycle-toolkit-charts/blob/821ad3dfa4c259d8fa2ba0e439f8bf8dd7064021/charts/common/templates/_images.tpl#L66

Creating another pr in the lifecycle-toolkit-charts
CC @mowies

@RealAnna RealAnna dismissed their stale review February 1, 2024 08:29

need to verify why the values order is not respected

@RealAnna RealAnna added the on hold Do not merge yet label Feb 7, 2024
@RealAnna RealAnna force-pushed the feature/imagePullPolicy-for-Chart branch from 781665b to b5775d0 Compare February 19, 2024 14:15
odubajDT
odubajDT previously approved these changes Feb 19, 2024
@RealAnna RealAnna removed the on hold Do not merge yet label Feb 19, 2024
Signed-off-by: Griffin <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 5596d12 into keptn:main Feb 20, 2024
37 of 38 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Griffin <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: RealAnna <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global value for imagePullPolicy
4 participants