Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator)!: move API HUB version to v1beta1 #2772

Merged
merged 15 commits into from
Jan 10, 2024
Merged

feat(lifecycle-operator)!: move API HUB version to v1beta1 #2772

merged 15 commits into from
Jan 10, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 9, 2024

Fixes: #2575

Changes

  • move HUB version to v1beta1
  • adapted conversion webhooks
  • remove usage of v1alpha* versions outside of /apis/lifecycle folder
  • remove conversion webhooks for deprecated resources - KeptnWorkloadInstance, KeptnEvaluationProvider

@odubajDT odubajDT changed the title Feat/2575/controllers beta feat(lifecycle-operator): move API HUB version to v1beta1 Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (ba3d8a5) 86.56% compared to head (322d57c) 85.64%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   86.56%   85.64%   -0.92%     
==========================================
  Files         169      160       -9     
  Lines       11178    10139    -1039     
==========================================
- Hits         9676     8684     -992     
+ Misses       1220     1174      -46     
+ Partials      282      281       -1     
Files Coverage Δ
...-operator/apis/lifecycle/v1alpha1/common/common.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha1/keptnapp_conversion.go 100.00% <100.00%> (ø)
...s/lifecycle/v1alpha1/keptnappversion_conversion.go 100.00% <100.00%> (ø)
.../lifecycle/v1alpha1/keptnworkloadinstance_types.go 100.00% <ø> (+9.23%) ⬆️
...-operator/apis/lifecycle/v1alpha2/common/common.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha2/keptnapp_conversion.go 100.00% <100.00%> (ø)
...s/lifecycle/v1alpha2/keptnappversion_conversion.go 100.00% <100.00%> (ø)
...ifecycle/v1alpha2/keptnevaluationprovider_types.go 100.00% <ø> (ø)
.../lifecycle/v1alpha2/keptnworkloadinstance_types.go 100.00% <ø> (+4.67%) ⬆️
...-operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <ø> (ø)
... and 62 more
Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.84% <77.90%> (+0.76%) ⬆️
lifecycle-operator 84.72% <90.64%> (-1.56%) ⬇️
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added ops documentation Improvements or additions to documentation labels Jan 9, 2024
@odubajDT odubajDT changed the title feat(lifecycle-operator): move API HUB version to v1beta1 feat(lifecycle-operator)!: move API HUB version to v1beta1 Jan 9, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

15.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@odubajDT odubajDT marked this pull request as ready for review January 10, 2024 11:47
@odubajDT odubajDT requested a review from a team as a code owner January 10, 2024 11:47
@odubajDT odubajDT merged commit 5d7ebbd into keptn:main Jan 10, 2024
48 of 49 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Dubaj <[email protected]>
Co-authored-by: Dubaj <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use v1beta1 API in lifecycle-operator controllers
3 participants