Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm-chart): remove double templating of annotations #2770

Merged
merged 7 commits into from
Jan 9, 2024
Merged

fix(helm-chart): remove double templating of annotations #2770

merged 7 commits into from
Jan 9, 2024

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 8, 2024

This pr fixes #2768

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba3d8a5) 86.56% compared to head (d213c26) 86.62%.
Report is 2 commits behind head on main.

❗ Current head d213c26 differs from pull request most recent head 2e6b944. Consider uploading reports for the commit 2e6b944 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
+ Coverage   86.56%   86.62%   +0.06%     
==========================================
  Files         169      169              
  Lines       11178    11178              
==========================================
+ Hits         9676     9683       +7     
+ Misses       1220     1215       -5     
+ Partials      282      280       -2

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.12% <ø> (+1.03%) ⬆️
lifecycle-operator 86.28% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna changed the title fix(charts): remove double import bug fix(helm-chart): remove double import bug Jan 8, 2024
@RealAnna RealAnna changed the title fix(helm-chart): remove double import bug fix(helm-chart): remove double templating of annotations Jan 8, 2024
@RealAnna RealAnna marked this pull request as ready for review January 8, 2024 11:29
@RealAnna RealAnna requested a review from a team as a code owner January 8, 2024 11:29
@RealAnna RealAnna mentioned this pull request Jan 8, 2024
Merged
8 tasks
odubajDT
odubajDT requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt also the newly added 'KeptnAppContext' CRD

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit b7a1d29 into main Jan 9, 2024
24 of 25 checks passed
@RealAnna RealAnna deleted the fix/helm-charts branch January 9, 2024 10:41
This was referenced Jan 9, 2024
Merged
Merged
Merged
@sudiptob2 sudiptob2 mentioned this pull request Jan 12, 2024
Closed
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@RealAnna @Vickysomtee
fix(helm-chart): remove double templating of annotations (keptn#2770)
8d0d626 
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
cert-manager lifecycle-operator metrics-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm chart with double annotations
3 participants
@RealAnna @bacherfl @odubajDT