-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add KUTTL collectors for scheduling gate tests #2723
Merged
RealAnna
merged 4 commits into
keptn:main
from
sudiptob2:test/2700/add-collector-to-scheduling-gate
Jan 24, 2024
Merged
test: add KUTTL collectors for scheduling gate tests #2723
RealAnna
merged 4 commits into
keptn:main
from
sudiptob2:test/2700/add-collector-to-scheduling-gate
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sudipto baral <[email protected]>
…699/add-collector-to-scheduling-gate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
==========================================
+ Coverage 85.72% 85.75% +0.02%
==========================================
Files 160 160
Lines 10163 10163
==========================================
+ Hits 8712 8715 +3
+ Misses 1171 1169 -2
+ Partials 280 279 -1 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
reviewed
Jan 12, 2024
…699/add-collector-to-scheduling-gate
Signed-off-by: sudipto baral <[email protected]>
Quality Gate failedFailed conditions 15.1% Duplication on New Code (required ≤ 3%) |
mowies
changed the title
test: add KUTTL collectors for scheduling gate tests.
test: add KUTTL collectors for scheduling gate tests
Jan 15, 2024
odubajDT
approved these changes
Jan 24, 2024
RealAnna
approved these changes
Jan 24, 2024
thank you for the contribution @sudiptob2 ! 🚀 |
7 tasks
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: sudipto baral <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a few collectors for now to discuss the issue further. Output is available in
test-result.txt
Fixes #2700
How to test
We have to manually fail a test and then check if the collectors are giving the expected output or not. In this case,
scheduling gate integration tests
are failing in my local machine without modifying anything. So I get above output described in test-result.txtPossible command: