Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add KUTTL collectors for scheduling gate tests #2723

Merged

Conversation

sudiptob2
Copy link
Member

@sudiptob2 sudiptob2 commented Dec 21, 2023

Description

I added a few collectors for now to discuss the issue further. Output is available in
test-result.txt

Fixes #2700

How to test

We have to manually fail a test and then check if the collectors are giving the expected output or not. In this case, scheduling gate integration tests are failing in my local machine without modifying anything. So I get above output described in test-result.txt
Possible command:

make integration-test-scheduling-gates-local

@sudiptob2 sudiptob2 marked this pull request as ready for review January 9, 2024 19:15
@sudiptob2 sudiptob2 requested a review from a team as a code owner January 9, 2024 19:15
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b77191c) 85.72% compared to head (12c462b) 85.75%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2723      +/-   ##
==========================================
+ Coverage   85.72%   85.75%   +0.02%     
==========================================
  Files         160      160              
  Lines       10163    10163              
==========================================
+ Hits         8712     8715       +3     
+ Misses       1171     1169       -2     
+ Partials      280      279       -1     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.12% <ø> (+0.96%) ⬆️
lifecycle-operator 84.72% <ø> (ø)
metrics-operator 87.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

15.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sudiptob2 sudiptob2 requested a review from RealAnna January 13, 2024 01:33
@mowies mowies changed the title test: add KUTTL collectors for scheduling gate tests. test: add KUTTL collectors for scheduling gate tests Jan 15, 2024
@RealAnna
Copy link
Contributor

thank you for the contribution @sudiptob2 ! 🚀

@RealAnna RealAnna merged commit 5988936 into keptn:main Jan 24, 2024
32 of 33 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collectors to Scheduling Gate Integration Tests
3 participants