Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup workload dashboard as default in observability example #2711

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Dec 20, 2023

closes #1816

image

this pr sets up DORA dashboard as default in the observability example and renames it to help the user understand the data

@RealAnna RealAnna requested a review from a team as a code owner December 20, 2023 14:35
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 555143b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6582fbad20ff820009d30303
😎 Deploy Preview https://deploy-preview-2711--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa1abf0) 85.48% compared to head (4e216dc) 85.47%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
- Coverage   85.48%   85.47%   -0.01%     
==========================================
  Files         155      155              
  Lines       10175    10178       +3     
==========================================
+ Hits         8698     8700       +2     
- Misses       1198     1199       +1     
  Partials      279      279              

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (-0.01%) ⬇️
component-tests 56.15% <ø> (-0.21%) ⬇️
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna force-pushed the chore/grafana-default branch from 6a2a672 to 29b7972 Compare December 21, 2023 07:57
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit 1561460 into main Dec 21, 2023
35 checks passed
@RealAnna RealAnna deleted the chore/grafana-default branch December 21, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make grafana dashboard compatible with helm chart and easy to install
3 participants